refactor(core): remove _tViewNode field from ViewRef #36814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
reviewed
Apr 27, 2020
| @@ -271,7 +273,7 @@ export class ComponentRef<T> extends viewEngine_ComponentRef<T> { | |||
| super(); | |||
| this.instance = instance; | |||
| this.hostView = this.changeDetectorRef = new RootViewRef<T>(_rootLView); | |||
| this.hostView._tViewNode = assignTViewNodeToLView(_rootLView[TVIEW], null, -1, _rootLView); | |||
| assignTViewNodeToLView(_rootLView[TVIEW], null, -1, _rootLView); | |||
There was a problem hiding this comment.
Can we remove the return value from assignTViewNodeToLView now? I can't find anywhere that uses it anymore.
There was a problem hiding this comment.
Done, good catch!
pkozlowski-opensource
force-pushed
the
_tViewNode_refactor
branch
from
ad1e84b
to
5b3fd59
Compare
pkozlowski-opensource
added
area: core
kara
added
action: cleanup
|
@pkozlowski-opensource Looks like this needs a rebase |
pkozlowski-opensource
force-pushed
the
_tViewNode_refactor
branch
from
5b3fd59
to
1124111
Compare
pkozlowski-opensource
added
action: cleanup
pkozlowski-opensource
force-pushed
the
_tViewNode_refactor
branch
from
1124111
to
1d23183
Compare
The _tViewNode field (that was marked as internal) on the ViewRef is not necessery as a reference to a relevant TView is available as a local variable.
pkozlowski-opensource
force-pushed
the
_tViewNode_refactor
branch
from
1d23183
to
c77389f
Compare
pkozlowski-opensource
added
action: merge
kara
pushed a commit
that referenced
this pull request
May 15, 2020
The _tViewNode field (that was marked as internal) on the ViewRef is not necessery as a reference to a relevant TView is available as a local variable. PR Close #36814
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
The _tViewNode field (that was marked as internal) on the ViewRef is not necessery as a reference to a relevant TView is available as a local variable. PR Close angular#36814
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _tViewNode field (that was marked as internal) on the ViewRef is not
necessary as a reference to a relevant TView is available as a local
variable.